From 55fba43ba65941477ac7876c3b03a985e059097b Mon Sep 17 00:00:00 2001 From: Juergen Gross Date: Wed, 23 Aug 2017 19:34:00 +0200 Subject: [PATCH] xen/arch/x86/io_apic.c: let custom parameter parsing routines return errno Modify the custom parameter parsing routines in: xen/arch/x86/io_apic.c to indicate whether the parameter value was parsed successfully. Signed-off-by: Juergen Gross Acked-by: Wei Liu Acked-by: Jan Beulich --- xen/arch/x86/io_apic.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index 2838f6bd99..f767c4560c 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -1581,7 +1581,7 @@ static unsigned int startup_level_ioapic_irq(struct irq_desc *desc) return 0; /* don't check for pending */ } -static void __init setup_ioapic_ack(char *s) +static int __init setup_ioapic_ack(const char *s) { if ( !strcmp(s, "old") ) { @@ -1594,7 +1594,12 @@ static void __init setup_ioapic_ack(char *s) ioapic_ack_forced = true; } else + { printk("Unknown ioapic_ack value specified: '%s'\n", s); + return -EINVAL; + } + + return 0; } custom_param("ioapic_ack", setup_ioapic_ack); -- 2.30.2